Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-fe: ProcessColumn QA #428

Merged
merged 5 commits into from
Aug 16, 2024
Merged

fix-fe: ProcessColumn QA #428

merged 5 commits into from
Aug 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 13, 2024

목적

ProcessColumn에 관한 QA를 진행합니다.

세부사항

  • ProcessColumn의 너비를 25rem으로 고정합니다.
  • ProcessColumn에 Description을 추가합니다.

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!


FIX_PROC_02

closes #427

@github-actions github-actions bot added fix 버그 수정 frontend 프론트엔드 labels Aug 13, 2024
@github-actions github-actions bot added this to the 스프린트 3.0 milestone Aug 13, 2024
@llqqssttyy llqqssttyy changed the title fix-fe: ProcessColumn의 최대 너비 지정 fix-fe: ProcessColumn QA Aug 13, 2024
Copy link
Contributor Author

1723621540.743559

Copy link
Contributor Author

1723621543.116119

@llqqssttyy llqqssttyy marked this pull request as ready for review August 14, 2024 07:45
Copy link
Contributor Author

1723621555.653269

Copy link
Contributor

@seongjinme seongjinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

렛서 감사합니다! column 사이즈, description 내용에 대한 ellipsis 처리와 더보기 버튼 모두 멋지게 잘 된 것 같아요 🙏

Comment on lines +10 to +12
const [showMore, setShowMore] = useState(false);

const toggleShowMore = () => setShowMore((prev) => !prev);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"더보기" 버튼 구현을 무척 깔끔하게 잘 해주신 것 같습니다! 👍

image

Copy link
Contributor

@lurgi lurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

센스있게 구현해주셨네용~ 스토리 하나 추가로 만드는 것 제안하나 해드립니다! 불필요하다 생각하시면 merge하십숑~

export default meta;
type Story = StoryObj<typeof ProcessDescription>;

export const Default: Story = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const Default: Story = {};
export const Default: Story = {};
export const LongDescription: Story = {
args: { description: '서류 접수 단계인가요? 아닌가요? 모르겠어요? 궁금해요?' },
};

@llqqssttyy llqqssttyy merged commit a03da65 into fe/develop Aug 16, 2024
11 checks passed
@llqqssttyy llqqssttyy deleted the fe-427-FIX_PROC_02 branch August 16, 2024 06:10
seongjinme pushed a commit that referenced this pull request Aug 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kim Da Eun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 frontend 프론트엔드
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants